This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Tests - Rewrite of C ELF tests to Rust or ASM #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
tests/migrate_c_to_rust
branch
4 times, most recently
from
c2b46c8 to
10fa0a0
Compare
alessandrod
approved these changes
Jul 13, 2023
Lichtso
force-pushed
the
tests/migrate_c_to_rust
branch
from
10fa0a0 to
a862689
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reevaluates which tests should actually need to be loaded from ELFs and rewrote those in Rust.
The rest was rewritten in assembler because we should not rely on the stability of the compiler output.