This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Limit - Reduce SYMBOL_NAME_LENGTH_MAXIMUM to 64
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrod
approved these changes
Jun 1, 2023
dmakarov
reviewed
Aug 12, 2023
| @@ -9,7 +9,7 @@ use crate::{ArithmeticOverflow, ErrCheckedArithmetic}; | |||
| use {consts::*, types::*}; | |||
|
|
|||
| const SECTION_NAME_LENGTH_MAXIMUM: usize = 16; | |||
| const SYMBOL_NAME_LENGTH_MAXIMUM: usize = 1024; | |||
| const SYMBOL_NAME_LENGTH_MAXIMUM: usize = 64; | |||
There was a problem hiding this comment.
This change makes it impossible to load files generated by our Move compiler. For example, this relocation triggers Unknown symbol error.
0000000000000578 000000250000000a R_BPF_64_32 000000000008d940 _ZN4core3fmt3num53_$LT$impl$u20$core..fmt..UpperHex$u20$for$u20$u16$GT$3fmt17hda2568c893a78314E
The symbol is 95 characters long. There are longer symbols in Move compiled modules too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.