Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Instruction Tracing #115

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Instruction Tracing #115

merged 6 commits into from
Nov 13, 2020

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Nov 12, 2020

Reimplements the instruction tracer for the interpreter and introduces it to the JIT as well.
Now the log is not printed directly but stored in a vector and used for testing.
The tests compare the trace logs of interpreter and JIT, thus make sure that they stay in sync on an instruction level.
The display formatting of the trace log is also more efficient than before,
as it only needs to disassemble the program once instead of for each line.

This feature uncovered two bugs in the JIT which were fixed as well.

The display formating is a lot more efficient than before as it only needs to disassemble the program once instead of for each line.
@Lichtso Lichtso added bug Something isn't working enhancement New feature or request labels Nov 12, 2020
@Lichtso Lichtso requested a review from jackcmay November 12, 2020 18:48
@Lichtso Lichtso force-pushed the feature/instruction_tracing branch from a581e98 to 2e94762 Compare November 13, 2020 11:59
@Lichtso Lichtso force-pushed the feature/instruction_tracing branch from 2e94762 to aa3de4b Compare November 13, 2020 13:53
@Lichtso Lichtso force-pushed the feature/instruction_tracing branch from 3f968a4 to 6e933b0 Compare November 13, 2020 17:13
@Lichtso Lichtso merged commit 2b08ab1 into solana-master Nov 13, 2020
@Lichtso Lichtso deleted the feature/instruction_tracing branch November 13, 2020 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant