Implement http proxy task #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barenboim
reviewed
May 20, 2021
src/factory/HttpTaskImpl.cc
Outdated
|
|
||
| using namespace protocol; | ||
|
|
||
| #define HTTP_KEEPALIVE_DEFAULT (60 * 1000) | ||
| #define HTTP_KEEPALIVE_MAX (300 * 1000) | ||
|
|
||
| static int __encode_auth(const char *p, std::string& auth) |
There was a problem hiding this comment.
这个移动到下面吧。毕竟和非proxy的情况没有关系。
src/factory/HttpTaskImpl.cc
Outdated
|
|
||
| BIO_free_all(b64); | ||
| return 0; | ||
| } |
| @@ -56,11 +123,11 @@ class ComplexHttpTask : public WFComplexClientTask<HttpRequest, HttpResponse> | |||
| virtual void init_failed(); | |||
| virtual bool finish_once(); | |||
|
|
|||
| private: | |||
src/factory/HttpTaskImpl.cc
Outdated
| return false; | ||
| } | ||
|
|
||
| if(user_uri_.scheme && strcasecmp(user_uri_.scheme, "http") == 0) |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can use http proxy when visit http(s) server now.