Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse test reports in the GH Actions workflow #53

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Parse test reports in the GH Actions workflow #53

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3541a20
Parse test reports in the GH Actions workflow
amorfis Nov 22, 2023
0db36a1
Comment added to `if: success() || failure()`
amorfis Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ jobs:
run: sbt -v compile
- name: Test
run: sbt -v test
- name: Test Report
uses: dorny/test-reporter@v1
if: success() || failure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a no-op? that is, can't we simply remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it means to run this step regardless if the previous one failed or succeeded. Without it test reports wouldn'd be parsed if any test failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok :) maybe add a comment, I think people might find it confusing (e.g. me ;) )

with:
name: 'Tests results'
path: '**/test-reports/TEST*.xml'
reporter: java-junit

publish:
name: Publish release
Expand Down