feat: implement Source.futureSource operator
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Oct 31, 2023
geminicaprograms
force-pushed
the
feat_future
branch
from
f18c916 to
31f8e48
Compare
geminicaprograms
commented
Nov 1, 2023
core/src/test/scala/ox/channels/SourceOpsFutureSourceTest.scala
Outdated
Show resolved
Hide resolved
geminicaprograms
force-pushed
the
feat_future
branch
from
31f8e48 to
c5a2f4a
Compare
geminicaprograms
commented
Nov 1, 2023
geminicaprograms
force-pushed
the
feat_futureSource
branch
from
ffe22ae to
e087ea9
Compare
rucek
reviewed
Nov 2, 2023
geminicaprograms
force-pushed
the
feat_futureSource
branch
from
e087ea9 to
8bdf162
Compare
adamw
reviewed
Nov 3, 2023
| def futureSource[T](from: Future[Source[T]])(using StageCapacity, ExecutionContext): Source[T] = | ||
| val c = StageCapacity.newChannel[T] | ||
| from.onComplete { | ||
| case Success(source) => supervised { source.pipeTo(c) } |
There was a problem hiding this comment.
we block in onComplete, which probably shouldn't happen - the pipe should only complete once all elements have been transmitted
There was a problem hiding this comment.
that's correct, 🤔 the other option would be to somehow pass the received (from onComplete -> Success) Source to another fork and process it there so that emission doesn't happen in the ExecutionContext. Let me think and propose sth there...
There was a problem hiding this comment.
yes, I think adding a source-transferring channel (with a buffer size of 1) would do the trick (plus a fork awaiting for the channel)
Creates a source that emits elements from future source when it completes or
fails otherwise. The future completion is performed on the provided
`ExecutionContext` whereas elements are emitted through Ox.
Note that when Future fails with `ExecutionException` then its cause is
returned as source failure.
Examples:
Source
.futureSource(Future.failed(new RuntimeException("future failed")))
.receive() // ChannelClosed.Error(Some(java.lang.RuntimeException: future failed))
Source.futureSource(Future.successful(Source.fromValues(1, 2))).toList // List(1, 2)
geminicaprograms
force-pushed
the
feat_futureSource
branch
from
8bdf162 to
6538ae0
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a source that emits elements from future source when it completes or fails otherwise. The future completion is performed on the provided
ExecutionContextwhereas elements are emitted throughSupervised. Note that when Future fails withExecutionExceptionthen its cause is returned as source failure.Examples: