Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Source.interleaveAll combinator #13
Add Source.interleaveAll combinator #13
Changes from 1 commit
895ba96
29ee6a6
a92e6ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since none of the sources is special, maybe this shoul dbe a method on
Source
-Source.interlaveAll
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside is that this would require us to handle the case of an empty list - but then I think we just return a done source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point with moving it to
Source
. As for the empty list - we can either return a done source as you suggest, or change the signature ofinterleaveAll
so that it enforces at least two sources (since one source would be a special case as well, where we just return the argument), e.g.The downside of the latter approach would be making the API inconsistent between
interleave
andinterleaveAll
. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's an inconsistency,
interleave
acts on two sources using the more convenient dot-notation, the...All
variant takes an arbitrary list. Thefirst
/second
approach would be good, but then it enforces static structure - won't work if you have a dynamically-defined list of sources.