fix: currentColor overflow #2570
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
added a commit
that referenced
this pull request
Dec 16, 2024
# Summary This is another fix for issue #2566 that also resets the color on prepareForRecycle (in the same manner of this fix #2570). I also don't have a sandboxed reproduce, but was able to verify the fix on my company's code which I unfortunately can't share. ## Compatibility OS | Implemented -- | -- iOS | ✅ MacOS | ✅ Co-authored-by: Jakub Grzywacz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a blind fix for issue #2566 that resets the caller on
prepareForRecycle. While it should help address the overflow happening in some cases, I cannot guarantee that it will fully resolve the issue due to the lack of a reproducible scenario.Compatibility