Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): missing background color for formSheets on RN 0.77+ #2660

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jan 29, 2025

Description

Caution

This PR breaks compatibility with older versions of react-native. While this is fine on Fabric, this also breaks things for Paper.
Possible solution is to detect react native version in gradle and add versioned sourcesets with implementations for given react native versions.

Not up to date. I've added versioned source files to ensure appropriate backward compatibility down to 0.74.

Note

We need CI to ensure the projects do build on all versions we support.

Changes

Migrated to BackgroundStyleApplicator API to resolve background color of contentWrapper.

Test code and steps to reproduce

TestAndroidTransitions - the form sheet should no longer be cut.

Checklist

  • Ensured that CI passes

@kkafar kkafar force-pushed the @kkafar/formsheet-fixes-background-color branch from 7b163de to 0fe34e6 Compare January 29, 2025 10:45
@kkafar kkafar force-pushed the @kkafar/formsheet-fixes-background-color branch from 320ec31 to 008f5bb Compare January 31, 2025 12:35
@kkafar kkafar merged commit 32c3a19 into main Jan 31, 2025
4 checks passed
@kkafar kkafar deleted the @kkafar/formsheet-fixes-background-color branch January 31, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant