fix(Android): missing background color for formSheets on RN 0.77+ #2660
+64
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BackgroundStyleApplicator
ColorDrawable
used previously byReactViewGroup
has been exchanged forCompositeBackgroundDrawable
added in Add CompositeBackgroundDrawable and BackgroundStyleApplicator facebook/react-native#45688Caution
This PR breaks compatibility with older versions of react-native. While this is fine on Fabric, this also breaks things for Paper.Possible solution is to detect react native version in gradle and add versioned sourcesets with implementations for given react native versions.Not up to date. I've added versioned source files to ensure appropriate backward compatibility down to 0.74.
Note
We need CI to ensure the projects do build on all versions we support.
Changes
Migrated to
BackgroundStyleApplicator API
to resolve background color ofcontentWrapper
.Test code and steps to reproduce
TestAndroidTransitions
- the form sheet should no longer be cut.Checklist