fix(Android): Restore focus on page transitions #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If lastFocusedChild was set (which only happens on Android TV), call requestFocus() onStart()
|
Yeah, the code was accidentally removed in #2045. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #1894 was merged, a refactoring of the native source happened, and the call to
lastFocusedChild.requestFocus()that happened on the overriddenonStart()method inScreenStackFragmentgot lost along the way, making focus disappear when popping a screen from the stack.Fixes #1706
Changes
ScreenStackFragment.kt, resurrecting the oldonStart()override (lastFocusedChildis only set on Android TV, so this change only affects that platform)