Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing guide #2140

Merged
merged 33 commits into from
Jun 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a1542d6
chore: update contributing guide
maciekstosio May 17, 2024
eac922d
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
6affe06
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
88a8708
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
369c0b4
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
493af4d
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
a853562
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
1d6505e
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
e460e53
Update guides/CONTRIBUTING.md
maciekstosio May 17, 2024
4bb3d6a
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
19d5dff
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
333cced
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
f53024a
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
cd29b95
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
26c79a2
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
ebde0a8
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
f0e9281
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
f30b3fe
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
2f18740
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
c86c3e5
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
366212b
Update guides/CONTRIBUTING.md
maciekstosio May 21, 2024
8a3d2f4
fix: add changes from comments
maciekstosio May 21, 2024
08153b2
fix: add changes based on components
maciekstosio May 21, 2024
66516d3
chore: update docs after unification of examples and test-examples
maciekstosio May 28, 2024
b4ed2ce
chore: add changes from comments
maciekstosio Jun 3, 2024
4e7c2cf
chore: update docs according to PR comments
maciekstosio Jun 4, 2024
54c3e6d
chore: update native-stack description
maciekstosio Jun 4, 2024
596eb79
Update CONTRIBUTING.md
maciekstosio Jun 4, 2024
ab83052
Update guides/CONTRIBUTING.md
maciekstosio Jun 11, 2024
c51c184
Update guides/CONTRIBUTING.md
maciekstosio Jun 11, 2024
b82d019
Update guides/CONTRIBUTING.md
maciekstosio Jun 11, 2024
078b435
Update guides/CONTRIBUTING.md
maciekstosio Jun 11, 2024
34c7abc
Update guides/CONTRIBUTING.md
maciekstosio Jun 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update guides/CONTRIBUTING.md
Co-authored-by: Kacper Kafara <[email protected]>
  • Loading branch information
maciekstosio and kkafar authored May 21, 2024
commit 19d5dffbe43dffb03a52a23860ade079d7f3bfb1
2 changes: 1 addition & 1 deletion guides/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ If you're changing core functionality:
- If you're adding a new feature or changing API, you **need to** create a PR in `react-navigation` repository.

> [!TIP]
> As the rule of thumb, if you're changing the external interface, you need to prepare PRs for the `react-navigation` repository.
> As the rule of thumb, if you're changing the public interface, you need to prepare PRs for the `react-navigation` repository.

### What is the flow to integrate with react-navigation

Expand Down
Loading