-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Publish fabric and classic architecture release #1308
Merged
Merged
Changes from 116 commits
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
cec0c26
Adds new fabric example
Ubax 7640e12
adds iOS fabric changes
Ubax 139a35b
Adds JS code of PoC and links it in package json
Ubax 94331d0
Adds screens iOS PoC
Ubax 91d72f1
Adds patches
Ubax e3a96c2
Changes prop show to hidden
Ubax 8c010f5
Adds README
Ubax 054ae53
Adds fabric changes for android
Ubax 93217e4
Adds patch for emulator localhost
Ubax 9a00c71
Adds react native as source dependency
Ubax e7f91e4
Adds native necessary files
Ubax f835211
Adds android changes to basic screens components
Ubax 69af2ba
Removes leftover comments from Android code
Ubax 75e42aa
Refactors JS components
Ubax 59ab207
Removes leftover comments
Ubax 0aaba53
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 1fc6d23
Refactors JS components
Ubax 6d12b61
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 9d505a9
Add resolve plugin
Ubax 8fb1188
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 84e027e
Removes leftover comments
Ubax 73c5abf
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax f2b353e
Renames includes on iOS to use rnscreens
Ubax da1226c
Removes _controller=nil from recycle
Ubax d6c0b0e
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 77b12b3
Adds information about Java 11 to README
Ubax d9bedb3
Fixes events dispatching in screen
Ubax 3fdd3cd
Removes unsued code
Ubax 114303c
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 60fab66
Adds example with react navigation
Ubax 5c0fefe
Adds dismiss event to iOS
Ubax 35b438b
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 811cb8f
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 27e6b64
Remove safe area java code
Ubax 8300aa7
Fix pop animation with props (JS + iOS)
Ubax b078768
Removes conditions from events notifications
Ubax 27314c9
Fixes ios clang format
Ubax 25c9504
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax f4a37fb
Fixes android format command
Ubax a88f709
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 8ff3184
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax b6eae2d
Adds check for key in screen stack children
Ubax e3a47da
Probable solution if mutations order changes
Ubax 4157680
Update react native version and remove patches
Ubax 3ff4603
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax fdebee4
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax bff934b
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax 50404fc
Adds more props to header config
Ubax d746f90
Adds JS more complex example
Ubax 36cc005
Fix unintentional change to ScreensSpec
Ubax 28d19c4
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 3ce017a
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax 84cd443
Merge branch '@ubax/fabric-fix-pop-animation' into @ubax/fabric-add-m…
Ubax 30850d4
Changes unmounting to use mounting observer
Ubax 3236937
Merge branch '@ubax/fabric-fix-pop-animation' into @ubax/fabric-add-m…
Ubax 3060d55
Fixes back button title on iOS
Ubax 5ec3e2e
Adds new props to Android Header Config
Ubax d7bb845
Adds example with chapters
Ubax 74462ff
Improves demo on Android
Ubax 0cb0f5e
Adds common to files and publishes tgz
Ubax 97a67c2
Updates README to mention fabric
Ubax 61c9eda
Adds combined podspec for paper and fabric
Ubax 11b9e0a
Adds screens as tgz dependency to example app
Ubax 09b6007
Updates podfile in FabricExample
Ubax c9c572c
Adds codegen generated android files
Ubax d1887fe
Updates podfile in FabricExample
Ubax 57e645b
Merge branch '@ubax/publish-poc' into @ubax/publish-fabric-classic
Ubax 8c8d6c6
Updates fabric readme to include android changes
Ubax b0defb1
Adds flags to enble fabric
Ubax 0d83832
Reverts example app to base version
Ubax 071bdb6
Merge branch 'main' into @ubax/publish-fabric-classic
Ubax ca51fce
Fixes minor bugs in index file
Ubax 06ef57a
Merge branch 'main' into @ubax/fabric-example-app-3
Ubax 5c71ccc
Merge branch '@ubax/fabric-example-app-3' into @ubax/fabric-ios-poc
Ubax fe3e241
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax 4e650fb
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 344aa01
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax 9e7d2b1
Merge branch '@ubax/fabric-fix-pop-animation' into @ubax/fabric-add-m…
Ubax b3102f1
Marges add-more-features to publish-poc
Ubax 6a0f07d
Marges add-more-features to publish-poc
Ubax c992af7
Merge branch '@ubax/publish-poc' into @ubax/publish-fabric-classic
Ubax 3eb5b7a
Adds cast to Screen so it works on 0.64
Ubax 9654ac4
Adds cast to Screen so it works on 0.64
Ubax 5e2da1f
Another minor change in index
Ubax e41fd1b
Changes podspec to use RCT_NEW_ARCH_ENABLED flag on iOS
Ubax 10f3bee
Unifies Podfile in example app with RN 68
Ubax 668a8a7
Add gradle function to 'remove' generated files on Android
Ubax eca2524
Add gradle function to 'remove' generated files on Android
Ubax d358096
Updates fabric readme
Ubax ed412ef
Adds condition for different screen on fabric and paper
Ubax c59ae3b
Removes hacks from gradle and uses sourceSets
Ubax 69e63ae
Adds flex to ScreenStack
Ubax 2ed283e
Update README fabric
Ubax dbc1c5c
Removes leftover .gitignore
Ubax 33dd3b7
Cleans code and prepares for release
Ubax 0f545e2
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax b484d5f
Cleans code and prepares for release
Ubax 24a4db6
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 53f9b78
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax b4cf6d9
Merge branch '@ubax/fabric-fix-pop-animation' into @ubax/publish-fabr…
Ubax 4796975
Refactors updateProps in Header Config
Ubax 36f47cc
Adds platform specific props comment
Ubax 5198eb7
Fixes controller typo
Ubax 48f688c
Merge branch '@ubax/fabric-ios-poc' into @ubax/fabric-android-poc
Ubax a72df9e
Formats build gradles
Ubax da0ba74
Merge branch '@ubax/fabric-android-poc' into @ubax/fabric-navigation-…
Ubax 743fa87
Merge branch '@ubax/fabric-navigation-example' into @ubax/fabric-fix-…
Ubax 641e5a5
Merge branch '@ubax/fabric-fix-pop-animation' into @ubax/publish-fabr…
Ubax 65db4b1
Removes rn patch for m1
Ubax d267301
Changes package version back
Ubax b99af0d
Adds small changes to Readme
Ubax 17fe593
Updates Podfile.lock
Ubax b15e62a
Adds missing whitespaces
Ubax 3a8396e
Adds warning for unimplemented subview
Ubax 60632f7
Applies proposals from code review
Ubax eb3d555
Updates Fabric Readme
Ubax e56f572
Merge branch 'main' into @ubax/publish-fabric-classic
Ubax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
[android] | ||
target = Google Inc.:Google APIs:23 | ||
|
||
[maven_repositories] | ||
central = https://repo1.maven.org/maven2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = { | ||
root: true, | ||
extends: '@react-native-community', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
[ignore] | ||
; We fork some components by platform | ||
.*/*[.]android.js | ||
|
||
; Ignore "BUCK" generated dirs | ||
<PROJECT_ROOT>/\.buckd/ | ||
|
||
; Ignore polyfills | ||
node_modules/react-native/Libraries/polyfills/.* | ||
|
||
; Flow doesn't support platforms | ||
.*/Libraries/Utilities/LoadingView.js | ||
|
||
[untyped] | ||
.*/node_modules/@react-native-community/cli/.*/.* | ||
|
||
[include] | ||
|
||
[libs] | ||
node_modules/react-native/interface.js | ||
node_modules/react-native/flow/ | ||
|
||
[options] | ||
emoji=true | ||
|
||
exact_by_default=true | ||
|
||
format.bracket_spacing=false | ||
|
||
module.file_ext=.js | ||
module.file_ext=.json | ||
module.file_ext=.ios.js | ||
|
||
munge_underscores=true | ||
|
||
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/node_modules/react-native/\1' | ||
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> '<PROJECT_ROOT>/node_modules/react-native/Libraries/Image/RelativeImageStub' | ||
|
||
suppress_type=$FlowIssue | ||
suppress_type=$FlowFixMe | ||
suppress_type=$FlowFixMeProps | ||
suppress_type=$FlowFixMeState | ||
|
||
[lints] | ||
sketchy-null-number=warn | ||
sketchy-null-mixed=warn | ||
sketchy-number=warn | ||
untyped-type-import=warn | ||
nonstrict-import=warn | ||
deprecated-type=warn | ||
unsafe-getters-setters=warn | ||
unnecessary-invariant=warn | ||
signature-verification-failure=warn | ||
|
||
[strict] | ||
deprecated-type | ||
nonstrict-import | ||
sketchy-null | ||
unclear-type | ||
unsafe-getters-setters | ||
untyped-import | ||
untyped-type-import | ||
|
||
[version] | ||
^0.168.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# OSX | ||
# | ||
.DS_Store | ||
|
||
# Xcode | ||
# | ||
build/ | ||
*.pbxuser | ||
!default.pbxuser | ||
*.mode1v3 | ||
!default.mode1v3 | ||
*.mode2v3 | ||
!default.mode2v3 | ||
*.perspectivev3 | ||
!default.perspectivev3 | ||
xcuserdata | ||
*.xccheckout | ||
*.moved-aside | ||
DerivedData | ||
*.hmap | ||
*.ipa | ||
*.xcuserstate | ||
|
||
# Android/IntelliJ | ||
# | ||
build/ | ||
.idea | ||
.gradle | ||
local.properties | ||
*.iml | ||
*.hprof | ||
|
||
# node.js | ||
# | ||
node_modules/ | ||
npm-debug.log | ||
yarn-error.log | ||
|
||
# BUCK | ||
buck-out/ | ||
\.buckd/ | ||
*.keystore | ||
!debug.keystore | ||
|
||
# fastlane | ||
# | ||
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the | ||
# screenshots whenever they are needed. | ||
# For more information about the recommended setup visit: | ||
# https://docs.fastlane.tools/best-practices/source-control/ | ||
|
||
*/fastlane/report.xml | ||
*/fastlane/Preview.html | ||
*/fastlane/screenshots | ||
|
||
# Bundle artifact | ||
*.jsbundle | ||
|
||
# CocoaPods | ||
/ios/Pods/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
module.exports = { | ||
arrowParens: 'avoid', | ||
bracketSameLine: true, | ||
bracketSpacing: false, | ||
singleQuote: true, | ||
trailingComma: 'all', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import React from 'react'; | ||
import {createNativeStackNavigator} from '@react-navigation/native-stack'; | ||
import {NavigationContainer} from '@react-navigation/native'; | ||
import {I18nManager} from 'react-native'; | ||
import Chapter from './src/Chapter'; | ||
import chapters from './src/chapters'; | ||
import HeaderDemo from './src/HeaderDemo'; | ||
import {WHITE} from './src/colors'; | ||
import {enableFabric} from 'react-native-screens'; | ||
|
||
const Stack = createNativeStackNavigator(); | ||
|
||
enableFabric(); | ||
|
||
const App = () => ( | ||
<NavigationContainer> | ||
<Stack.Navigator | ||
screenOptions={{ | ||
headerHideBackButton: true, | ||
direction: I18nManager.isRTL ? 'rtl' : 'ltr', | ||
}}> | ||
<Stack.Screen | ||
name="Chapter" | ||
options={{ | ||
title: 'Fabric Example', | ||
headerShown: false, | ||
}} | ||
initialParams={{ | ||
index: 0, | ||
chapters: chapters, | ||
chapterRoute: 'Chapter', | ||
afterChapterRoute: 'HeaderDemo', | ||
}} | ||
component={Chapter} | ||
/> | ||
<Stack.Screen | ||
name="HeaderDemo" | ||
component={HeaderDemo} | ||
options={{title: 'Header Demo', headerTintColor: WHITE}} | ||
/> | ||
</Stack.Navigator> | ||
</NavigationContainer> | ||
); | ||
|
||
export default App; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
source 'https://rubygems.org' | ||
|
||
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
ruby '2.7.0' | ||
|
||
gem 'cocoapods', '~> 1.11', '>= 1.11.2' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
CFPropertyList (3.0.5) | ||
rexml | ||
activesupport (6.1.4.4) | ||
concurrent-ruby (~> 1.0, >= 1.0.2) | ||
i18n (>= 1.6, < 2) | ||
minitest (>= 5.1) | ||
tzinfo (~> 2.0) | ||
zeitwerk (~> 2.3) | ||
addressable (2.8.0) | ||
public_suffix (>= 2.0.2, < 5.0) | ||
algoliasearch (1.27.5) | ||
httpclient (~> 2.8, >= 2.8.3) | ||
json (>= 1.5.1) | ||
atomos (0.1.3) | ||
claide (1.0.3) | ||
cocoapods (1.11.2) | ||
addressable (~> 2.8) | ||
claide (>= 1.0.2, < 2.0) | ||
cocoapods-core (= 1.11.2) | ||
cocoapods-deintegrate (>= 1.0.3, < 2.0) | ||
cocoapods-downloader (>= 1.4.0, < 2.0) | ||
cocoapods-plugins (>= 1.0.0, < 2.0) | ||
cocoapods-search (>= 1.0.0, < 2.0) | ||
cocoapods-trunk (>= 1.4.0, < 2.0) | ||
cocoapods-try (>= 1.1.0, < 2.0) | ||
colored2 (~> 3.1) | ||
escape (~> 0.0.4) | ||
fourflusher (>= 2.3.0, < 3.0) | ||
gh_inspector (~> 1.0) | ||
molinillo (~> 0.8.0) | ||
nap (~> 1.0) | ||
ruby-macho (>= 1.0, < 3.0) | ||
xcodeproj (>= 1.21.0, < 2.0) | ||
cocoapods-core (1.11.2) | ||
activesupport (>= 5.0, < 7) | ||
addressable (~> 2.8) | ||
algoliasearch (~> 1.0) | ||
concurrent-ruby (~> 1.1) | ||
fuzzy_match (~> 2.0.4) | ||
nap (~> 1.0) | ||
netrc (~> 0.11) | ||
public_suffix (~> 4.0) | ||
typhoeus (~> 1.0) | ||
cocoapods-deintegrate (1.0.5) | ||
cocoapods-downloader (1.5.1) | ||
cocoapods-plugins (1.0.0) | ||
nap | ||
cocoapods-search (1.0.1) | ||
cocoapods-trunk (1.6.0) | ||
nap (>= 0.8, < 2.0) | ||
netrc (~> 0.11) | ||
cocoapods-try (1.2.0) | ||
colored2 (3.1.2) | ||
concurrent-ruby (1.1.9) | ||
escape (0.0.4) | ||
ethon (0.15.0) | ||
ffi (>= 1.15.0) | ||
ffi (1.15.4) | ||
fourflusher (2.3.1) | ||
fuzzy_match (2.0.4) | ||
gh_inspector (1.1.3) | ||
httpclient (2.8.3) | ||
i18n (1.8.11) | ||
concurrent-ruby (~> 1.0) | ||
json (2.6.1) | ||
minitest (5.15.0) | ||
molinillo (0.8.0) | ||
nanaimo (0.3.0) | ||
nap (1.1.0) | ||
netrc (0.11.0) | ||
public_suffix (4.0.6) | ||
rexml (3.2.5) | ||
ruby-macho (2.5.1) | ||
typhoeus (1.4.0) | ||
ethon (>= 0.9.0) | ||
tzinfo (2.0.4) | ||
concurrent-ruby (~> 1.0) | ||
xcodeproj (1.21.0) | ||
CFPropertyList (>= 2.3.3, < 4.0) | ||
atomos (~> 0.1.3) | ||
claide (>= 1.0.2, < 2.0) | ||
colored2 (~> 3.1) | ||
nanaimo (~> 0.3.0) | ||
rexml (~> 3.2.4) | ||
zeitwerk (2.5.3) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
cocoapods (~> 1.11, >= 1.11.2) | ||
|
||
RUBY VERSION | ||
ruby 2.7.0p0 | ||
|
||
BUNDLED WITH | ||
2.2.31 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# React Native Screens example app that uses fabric architecture | ||
|
||
## Installing & running application | ||
|
||
Before running application you need to install all dependencies. To do that: | ||
- In project's root directory run `yarn install` | ||
- In FabricExample directory run `yarn install` | ||
|
||
### Android | ||
|
||
To run this application on Android you need to have Java 11 active on your computer. You can check which version you are using by running `javac --version`. You can change it by changing `JAVA_HOME` environment variable or in Android Studio settings. | ||
|
||
Then you can run this application by `yarn android` or from Android Studio. | ||
|
||
### iOS | ||
|
||
To run on iOS first go to `FabricExample/ios` and run `RCT_NEW_ARCH_ENABLED=1 pod install`. This will install pods for Fabric architecture. | ||
|
||
Then in `FabricExample` run `yarn ios` or run application from Xcode. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/** | ||
* @format | ||
*/ | ||
|
||
import 'react-native'; | ||
import React from 'react'; | ||
import App from '../App'; | ||
|
||
// Note: test renderer must be required after react-native. | ||
import renderer from 'react-test-renderer'; | ||
|
||
it('renders correctly', () => { | ||
renderer.create(<App />); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
BUNDLE_PATH: "vendor/bundle" | ||
BUNDLE_FORCE_RUBY_PLATFORM: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2.7.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use v5 version of
native-stack
since it will get all the files straight from our repo? If not, could you check if we files imported fromreact-native-screens
inside@react-navigation/native-stack
are taken from our repo and not as some other version in itsnode_modules
?