A bit more of cleanup & refactor of iOS code

software-mansion · Jan 15, 2025 · f6f78c2 · f6f78c2
1 parent 2703a0f
commit f6f78c2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/ios/RNSScreenStack.mm b/ios/RNSScreenStack.mm
@@ -116,7 +116,7 @@ - (void)maybeUpdateHeaderInsetsInShadowTreeForScreen:(RNSScreen *)screenControll
   [headerConfig updateHeaderConfigState:self.navigationBar.frame.size];
   for (RNSScreenStackHeaderSubview *subview in headerConfig.reactSubviews) {
     CGRect frameInNavBarCoordinates = [subview convertRect:subview.frame toView:self.navigationBar];
-    [subview updateHeaderSubviewFrame:frameInNavBarCoordinates];
+    [subview updateHeaderSubviewFrameInShadowTree:frameInNavBarCoordinates];
   }
 #else
   NSDirectionalEdgeInsets navBarMargins = [self.navigationBar directionalLayoutMargins];

diff --git a/ios/RNSScreenStackHeaderConfig.mm b/ios/RNSScreenStackHeaderConfig.mm
@@ -949,7 +949,7 @@ - (void)prepareForRecycle
   _initialPropsSet = NO;
 
 #ifdef RCT_NEW_ARCH_ENABLED
-  _lastSize = CGSize();
+  _lastSize = CGSizeZero;
 #else
   _lastHeaderInsets = NSDirectionalEdgeInsets{};
 #endif

diff --git a/ios/RNSScreenStackHeaderSubview.h b/ios/RNSScreenStackHeaderSubview.h
@@ -21,7 +21,7 @@ NS_ASSUME_NONNULL_BEGIN
 @property (nonatomic, weak) UIView *reactSuperview;
 
 #ifdef RCT_NEW_ARCH_ENABLED
-- (void)updateHeaderSubviewFrame:(CGRect)frame;
+- (void)updateHeaderSubviewFrameInShadowTree:(CGRect)frame;
 #endif
 
 @end

diff --git a/ios/RNSScreenStackHeaderSubview.mm b/ios/RNSScreenStackHeaderSubview.mm
@@ -137,7 +137,7 @@ - (void)updateState:(const facebook::react::State::Shared &)state
   _state = std::static_pointer_cast<const react::RNSScreenStackHeaderSubviewShadowNode::ConcreteState>(state);
 }
 
-- (void)updateHeaderSubviewFrame:(CGRect)frame
+- (void)updateHeaderSubviewFrameInShadowTree:(CGRect)frame
 {
   if (_state != nullptr) {
     auto newState =