Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass runtime reference from REAModule to NativeProxy on iOS #7215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass runtime reference from REAModule to NativeProxy on iOS #7215

wants to merge 2 commits into from
+4 −3

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Mar 9, 2025

Summary

Currently, in Reanimated we obtain runtime reference twice – once in installTurboModule in REAModule and then in createReanimatedModule in NativeProxy. This PR removes the second reinterpret_cast in favor of passing rnRuntime as createReanimatedModule argument.

Test plan

See if CI is green.

@tomekzaw tomekzaw requested review from piaskowyk and tjzel March 9, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

@tjzel tjzel Awaiting requested review from tjzel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomekzaw