Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EasingFunctionFactory type usage #6958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix EasingFunctionFactory type usage #6958

wants to merge 1 commit into from

Conversation

bartlomiejbloniarz
Copy link
Contributor

@bartlomiejbloniarz bartlomiejbloniarz commented Jan 30, 2025 •
edited by github-actions bot
Loading

Summary

This PR adds missing EasingFunctionFactory type, when it's needed (e.g. Keyframe Animations). It's needed for easings like Easing.bezier that return an easing factory function.

Test plan

tjzel
tjzel requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a minimal TypeScript test case so we know it works 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomiejbloniarz @tjzel