Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up dependencies of apps dependent on the common-app #6923

Merged
merged 17 commits into from
Jan 24, 2025
Merged

chore: Clean up dependencies of apps dependent on the common-app #6923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aa114d3
Clean up fabric example deps
MatiPl01 Jan 22, 2025
6caee8a
Clean up web example deps
MatiPl01 Jan 22, 2025
792fced
Remove linting and formatting from web-example
MatiPl01 Jan 22, 2025
50a174c
Fix some issues
MatiPl01 Jan 22, 2025
1485727
Remove unnecessary typecheck
MatiPl01 Jan 22, 2025
4208177
Disable eslint check for apps importing from common-app
MatiPl01 Jan 22, 2025
971bf3d
Restore lint commands
MatiPl01 Jan 23, 2025
8c47c76
Move common-app dependencies to a shared getter function
MatiPl01 Jan 23, 2025
8e71958
Update macos-example to use shared common-app dependencies, add depen…
MatiPl01 Jan 23, 2025
156f0b2
Add some files to tsconfig excludes, format files
MatiPl01 Jan 23, 2025
a39b8e5
Fix some issues
MatiPl01 Jan 23, 2025
d4cfd18
Try to fix macos build on CI
MatiPl01 Jan 23, 2025
32f15a6
Try with another ruby version
MatiPl01 Jan 24, 2025
6b16ff1
Try with newer bundler and ruby
MatiPl01 Jan 24, 2025
1d37b77
Another attempt
MatiPl01 Jan 24, 2025
5615761
Fix eslint config, remove .eslintignore for scripts
MatiPl01 Jan 24, 2025
6fddb59
Cleanup
MatiPl01 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore lint commands
  • Loading branch information
@MatiPl01
MatiPl01 committed Jan 24, 2025
commit 971bf3dac3d8a1c500dad90f48ffdb59095c8fb4
1 change: 1 addition & 0 deletions apps/fabric-example/ios/.ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.2.2
6 changes: 5 additions & 1 deletion apps/fabric-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@
"build": "cd ios && bundle install && bundle exec pod update",
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start"
"start": "react-native start",
"lint": "eslint --max-warnings=0 --ignore-pattern 'common-app/' ."
},
"dependencies": {
"common-app": "workspace:*",
"react-native": "0.77.0-rc.6"
},
"devDependencies": {
"eslint": "^8.57.0"
},
"engines": {
"node": ">=18"
}
Expand Down
2 changes: 2 additions & 0 deletions apps/web-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"start": "expo start --web",
"start:noplugin": "DISABLE_BABEL_PLUGIN=1 yarn start",
"production": "yarn expo export -p web && yarn serve dist --single",
"lint": "eslint --max-warnings=0 .",
"build": ""
},
"dependencies": {
Expand All @@ -19,6 +20,7 @@
"devDependencies": {
"@expo/metro-runtime": "~4.0.0",
"@stylexjs/babel-plugin": "^0.10.0",
"eslint": "^8.57.0",
"serve": "^14.2.3"
}
}
2 changes: 2 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12095,6 +12095,7 @@ __metadata:
resolution: "fabric-example@workspace:apps/fabric-example"
dependencies:
common-app: "workspace:*"
eslint: "npm:^8.57.0"
react-native: "npm:0.77.0-rc.6"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -21884,6 +21885,7 @@ __metadata:
"@expo/metro-runtime": "npm:~4.0.0"
"@stylexjs/babel-plugin": "npm:^0.10.0"
common-app: "workspace:*"
eslint: "npm:^8.57.0"
expo: "npm:^52.0.4"
react-dom: "npm:18.3.1"
react-native: "npm:0.77.0-rc.6"
Expand Down