refactor(Worklets): move UIScheduler #6789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/move-ui-scheduler
tjzel
force-pushed
the
@tjzel/worklets/move-ui-scheduler
branch
from
4289133 to
4e8e41c
Compare
tjzel
added
the
Check compatibility
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This pull requests moves `UIScheduler`, a class responsible for scheduling operations to the Main Thread, to Worklets. While it seems that `Reanimated` should have some freedom scheduling to the Main Thread if it doesn't use the UI Runtime, I think it's better to move it now as is and add some secondary APIs later on. We'll have a better overview of what we need once more code is moved to Worklets. ## Test plan - CI - [x] Working 0.76 Paper/Fabric iOS/Android
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This pull requests moves `UIScheduler`, a class responsible for scheduling operations to the Main Thread, to Worklets. While it seems that `Reanimated` should have some freedom scheduling to the Main Thread if it doesn't use the UI Runtime, I think it's better to move it now as is and add some secondary APIs later on. We'll have a better overview of what we need once more code is moved to Worklets. ## Test plan - CI - [x] Working 0.76 Paper/Fabric iOS/Android
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This pull requests moves `UIScheduler`, a class responsible for scheduling operations to the Main Thread, to Worklets. While it seems that `Reanimated` should have some freedom scheduling to the Main Thread if it doesn't use the UI Runtime, I think it's better to move it now as is and add some secondary APIs later on. We'll have a better overview of what we need once more code is moved to Worklets. ## Test plan - CI - [x] Working 0.76 Paper/Fabric iOS/Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests moves
UIScheduler, a class responsible for scheduling operations to the Main Thread, to Worklets. While it seems thatReanimatedshould have some freedom scheduling to the Main Thread if it doesn't use the UI Runtime, I think it's better to move it now as is and add some secondary APIs later on. We'll have a better overview of what we need once more code is moved to Worklets.Test plan