Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rephrase render shared value read warning #6785

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Dec 3, 2024

Summary

Turns out it can be understood that you should be using get in render instead of .value.

Test plan

@tjzel tjzel requested a review from MatiPl01 December 3, 2024 15:47
Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjzel tjzel added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit f6e54f7 Dec 3, 2024
10 checks passed
@tjzel tjzel deleted the @tjzel/docs/rephrase-shared-value-render-read-warning branch December 3, 2024 15:59
tjzel added a commit that referenced this pull request Dec 13, 2024
## Summary

Turns out it can be understood that you should be using `get` in render
instead of `.value`.

## Test plan
tjzel added a commit that referenced this pull request Dec 13, 2024
## Summary

Turns out it can be understood that you should be using `get` in render
instead of `.value`.

## Test plan
tjzel added a commit that referenced this pull request Dec 13, 2024
## Summary

Turns out it can be understood that you should be using `get` in render
instead of `.value`.

## Test plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants