refactor: restore JSCallInvoker #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
added
the
Check compatibility
tjzel
commented
Dec 3, 2024
...ct-native-reanimated/android/src/main/java/com/swmansion/worklets/JSCallInvokerResolver.java
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Dec 4, 2024
...ct-native-reanimated/android/src/main/java/com/swmansion/worklets/JSCallInvokerResolver.java
Outdated
Show resolved
Hide resolved
...ct-native-reanimated/android/src/main/java/com/swmansion/worklets/JSCallInvokerResolver.java
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/apple/reanimated/apple/REAModule.mm
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Dec 9, 2024
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
Merged
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out that majority of work with regards to using
RuntimeExecutordone incan be reverted since
jsCallInvokeris staying in the API.Thanks to that we can significantly cleanup the code which is helpful for Worklets.
Test plan
I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.