refactor: rename cpp NativeReanimatedModule to ReanimatedModuleProxy #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
added
the
Check compatibility
tomekzaw
approved these changes
Nov 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## Summary Analogous to: - #6766 `NativeWorkletsModule` is the name of the ObjC/Java modules generated from `WorkletsModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeWorkletsModule` becomes `WorkletsModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…6766) ## Summary `NativeReanimatedModule` is the name of the ObjC/Java modules generated from `REAModule` and `ReanimatedModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeReanimatedModule` becomes `ReanimatedModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Analogous to: - #6766 `NativeWorkletsModule` is the name of the ObjC/Java modules generated from `WorkletsModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeWorkletsModule` becomes `WorkletsModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…6766) ## Summary `NativeReanimatedModule` is the name of the ObjC/Java modules generated from `REAModule` and `ReanimatedModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeReanimatedModule` becomes `ReanimatedModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Analogous to: - #6766 `NativeWorkletsModule` is the name of the ObjC/Java modules generated from `WorkletsModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeWorkletsModule` becomes `WorkletsModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…6766) ## Summary `NativeReanimatedModule` is the name of the ObjC/Java modules generated from `REAModule` and `ReanimatedModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeReanimatedModule` becomes `ReanimatedModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Analogous to: - #6766 `NativeWorkletsModule` is the name of the ObjC/Java modules generated from `WorkletsModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeWorkletsModule` becomes `WorkletsModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NativeReanimatedModuleis the name of the ObjC/Java modules generated fromREAModuleandReanimatedModule. It's confusing that we name some Cpp object the same way. With this change CppNativeReanimatedModulebecomesReanimatedModuleProxy, the same name we use to refer to it from JavaScript.Test plan
CI