fix: Break circular reference in NativeProxy and AndroidUIScheduler
#6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
reviewed
Dec 24, 2024
...c/reactNativeVersionPatch/NativeProxyFabric/latest/com/swmansion/reanimated/NativeProxy.java
Outdated
Show resolved
Hide resolved
...act-native-reanimated/android/src/main/java/com/swmansion/reanimated/AndroidUIScheduler.java
Outdated
Show resolved
Hide resolved
Comment on lines
+278
to
+224
| // Module might be already destroyed. | ||
| if (!javaPart_) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I'm not a fan of checking this every time, but it sure is the best way if we don't want any refactors here. However, I'd much prefer something among the lines for transparency:
Suggested change
| // Module might be already destroyed. | |
| if (!javaPart_) { | |
| return; | |
| } | |
| if (invalidated) { | |
| return; | |
| } |
What do you think?
piaskowyk
approved these changes
Jan 9, 2025
lukmccall
force-pushed
the
@lukmccall/memory/break-cycle-ref-in-native-proxy
branch
from
b450de3 to
db174c8
Compare
lukmccall
force-pushed
the
@lukmccall/memory/break-cycle-ref-in-native-proxy
branch
from
db174c8 to
a733aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaks circular reference in
NativeProxyandAndroidUIScheduler.Needs #6671 to work.
NativeProxyandAndroidUIScheduleris aHybridClasswith a C++ counterpart holding a global reference to the Java object. This structure creates a circular reference between C++ and Java, which the garbage collector cannot clean up. To resolve this issue, I manually removed the reference between C++ and Java by resetting the global ref during the invalidation of theNativeProxyandAndroidUIScheduler.Test plan
I tested it with a new project using Expo (SDK 52) and with Fabric enabled. I reloaded the app several times and performed a heap dump to verify that everything was removed correctly.