fix: Allow TypeScript in worklet classes #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Nov 5, 2024
wcandillon
reviewed
Nov 18, 2024
apps/common-app/src/examples/RuntimeTests/tests/plugin/recursion.test.tsx
Show resolved
Hide resolved
bartlomiejbloniarz
approved these changes
Nov 19, 2024
tjzel
added a commit
that referenced
this pull request
Nov 20, 2024
Turns out `@babel/preset-typescript` always has to be included when calling `transformSync` from `babel` (it cannot be included in a later call). Due to that I made all `transformSync` calls into a wrapper call that uses a required set of plugins and presets. Fixes - #6642 - [x] Plugin unit tests pass - [x] Runtime tests pass
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out
@babel/preset-typescriptalways has to be included when callingtransformSyncfrombabel(it cannot be included in a later call). Due to that I made alltransformSynccalls into a wrapper call that uses a required set of plugins and presets.Fixes
Test plan