feat: Support for multiple surfaces on Fabric #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Oct 29, 2024
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Oct 29, 2024
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Show resolved
Hide resolved
|
Please merge latest main to fix macOS CI, looks like tvOS is still broken on other PRs |
|
I have tested it, and it crashes sometimes for me after a reload. What I did was I opened the Bokeh Example and pressed R to reload the app - on Android, it stops the animation, but on iOS, it crashes. Could you verify if this happened before as well? |
We established that this issue is not related to changes from this PR. |
piaskowyk
approved these changes
Nov 18, 2024
patrycjakalinska
deleted the
@patrycjakalinska/support-for-multiple-layers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces handling multiple surfaces on Fabric.
Test plan
🚀