Add ReanimatedSystraceSection
#6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
requested changes
Aug 6, 2024
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedProfilingSection.h
Outdated
Show resolved
Hide resolved
bartlomiejbloniarz
changed the title
tomekzaw
reviewed
Oct 29, 2024
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Dec 2, 2024
tjzel
reviewed
Dec 4, 2024
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedSystraceSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedSystraceSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedSystraceSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedSystraceSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Tools/ReanimatedSystraceSection.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Dec 4, 2024
…eanimatedSystraceSection.h Co-authored-by: Tomasz Żelawski <[email protected]>
…eanimatedSystraceSection.h Co-authored-by: Tomasz Żelawski <[email protected]>
…eanimatedSystraceSection.h Co-authored-by: Tomasz Żelawski <[email protected]>
…eanimatedSystraceSection.h Co-authored-by: Tomasz Żelawski <[email protected]>
…eanimatedSystraceSection.h Co-authored-by: Tomasz Żelawski <[email protected]>
|
Don't worry @bartlomiejbloniarz!!! |
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/add-profiling-macros
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
ReanimatedSystraceSectionclass that allow for easy marking of relevant code sections on Android (through ATrace) and iOS (through signposts).When
REANIMATED_PROFILINGis not defined the profiling code will compile tono-op, meaning we can have these systrace sections in our code permanently.Test plan