aRemove some unnecessary changes

software-mansion · Jan 31, 2025 · b247abf · b247abf
1 parent ada6b1f
commit b247abf
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 42 deletions.
diff --git a/apps/fabric-example/ios/Podfile.lock b/apps/fabric-example/ios/Podfile.lock
@@ -2250,7 +2250,7 @@ SPEC CHECKSUMS:
   RNCMaskedView: 308c763227e237d4d260bd8841870e099572bb3e
   RNFlashList: b799a0cdd1189c1f5064331548400dd79a7e3047
   RNGestureHandler: 70069ab3e0431b03f6e465b65745f87a1a02c6c0
-  RNReanimated: 046c859afe6454f541abddad6fb755d8abc83351
+  RNReanimated: 537897c4ac8d319041d74cd19b633a694fff3895
   RNScreens: 5d61e452b51e7c23b3fcb9f16c4967d683a60a9d
   RNSVG: 2089e8b3a145acb2f392017279790f007f934567
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748

diff --git a/packages/react-native-reanimated/Common/cpp/reanimated/CSS/core/CSSTransition.cpp b/packages/react-native-reanimated/Common/cpp/reanimated/CSS/core/CSSTransition.cpp
@@ -1,10 +1,6 @@
 #ifdef RCT_NEW_ARCH_ENABLED
 #include <reanimated/CSS/core/CSSTransition.h>
 
-#include <worklets/Tools/JSISerializer.h>
-
-using namespace worklets;
-
 namespace reanimated {
 
 CSSTransition::CSSTransition(
@@ -62,8 +58,6 @@ jsi::Value CSSTransition::run(
     jsi::Runtime &rt,
     const ChangedProps &changedProps,
     const double timestamp) {
-  LOG(INFO) << "CSSTransition run newProps: "
-            << stringifyJSIValue(rt, changedProps.newProps);
   progressProvider_.runProgressProviders(
       timestamp,
       changedProps.changedPropertyNames,

diff --git a/...reanimated/Common/cpp/reanimated/CSS/interpolation/styles/TransitionStyleInterpolator.cpp b/...reanimated/Common/cpp/reanimated/CSS/interpolation/styles/TransitionStyleInterpolator.cpp
@@ -36,10 +36,6 @@ TransitionStyleInterpolator::getReversedPropertyNames(
     const auto propertyValue = propertyValuesObject.getProperty(
         rt, jsi::PropNameID::forUtf8(rt, propertyName));
 
-    LOG(INFO) << "TransitionStyleInterpolator propertyName: " << propertyName;
-    LOG(INFO) << "TransitionStyleInterpolator propertyValue: "
-              << stringifyJSIValue(rt, propertyValue);
-
     const auto it = interpolators_.find(propertyName);
     if (it != interpolators_.end() &&
         it->second->equalsReversingAdjustedStartValue(rt, propertyValue)) {

diff --git a/...eact-native-reanimated/Common/cpp/reanimated/CSS/interpolation/values/ValueInterpolator.h b/...eact-native-reanimated/Common/cpp/reanimated/CSS/interpolation/values/ValueInterpolator.h
@@ -9,12 +9,8 @@
 #include <string>
 #include <vector>
 
-#include <worklets/Tools/JSISerializer.h>
-
 namespace reanimated {
 
-using namespace worklets;
-
 struct ValueInterpolatorUpdateContext {
   const ShadowNode::Shared &node;
 };
@@ -83,8 +79,6 @@ class ValueInterpolator : public PropertyInterpolator {
     if (!reversingAdjustedStartValue_.has_value()) {
       return propertyValue.isUndefined();
     }
-    LOG(INFO) << "ValueInterpolator equalsReversingAdjustedStartValue: "
-              << stringifyJSIValue(rt, propertyValue);
     return reversingAdjustedStartValue_.value() == ValueType(rt, propertyValue);
   }
 
@@ -100,8 +94,6 @@ class ValueInterpolator : public PropertyInterpolator {
         keyframes_.push_back(
             ValueKeyframe<AllowedTypes...>{offset, std::nullopt});
       } else {
-        LOG(INFO) << "ValueInterpolator keyframe value: "
-                  << stringifyJSIValue(rt, value);
         keyframes_.push_back(
             ValueKeyframe<AllowedTypes...>{offset, ValueType(rt, value)});
       }
@@ -115,11 +107,6 @@ class ValueInterpolator : public PropertyInterpolator {
     keyframeAfterIndex_ = 1;
     ValueKeyframe<AllowedTypes...> firstKeyframe, lastKeyframe;
 
-    LOG(INFO) << "ValueInterpolator oldStyleValue: "
-              << stringifyJSIValue(rt, oldStyleValue);
-    LOG(INFO) << "ValueInterpolator newStyleValue: "
-              << stringifyJSIValue(rt, newStyleValue);
-
     if (!oldStyleValue.isUndefined()) {
       reversingAdjustedStartValue_ = ValueType(rt, oldStyleValue);
     } else {
@@ -203,8 +190,6 @@ class ValueInterpolator : public PropertyInterpolator {
       jsi::Runtime &rt,
       const ShadowNode::Shared &shadowNode) const {
     const jsi::Value &styleValue = getStyleValue(rt, shadowNode);
-    LOG(INFO) << "ValueInterpolator fallback value: "
-              << stringifyJSIValue(rt, styleValue);
     return styleValue.isUndefined() ? defaultStyleValue_
                                     : ValueType(rt, styleValue);
   }

diff --git a/...ges/react-native-reanimated/Common/cpp/reanimated/CSS/registry/CSSTransitionsRegistry.cpp b/...ges/react-native-reanimated/Common/cpp/reanimated/CSS/registry/CSSTransitionsRegistry.cpp
@@ -1,12 +1,8 @@
 #ifdef RCT_NEW_ARCH_ENABLED
 #include <reanimated/CSS/registry/CSSTransitionsRegistry.h>
 
-#include <worklets/Tools/JSISerializer.h>
-
 namespace reanimated {
 
-using namespace worklets;
-
 CSSTransitionsRegistry::CSSTransitionsRegistry(
     const std::shared_ptr<StaticPropsRegistry> &staticPropsRegistry,
     const GetAnimationTimestampFunction &getCurrentTimestamp)
@@ -139,17 +135,6 @@ PropsObserver CSSTransitionsRegistry::createPropsObserver(const Tag viewTag) {
         transition->getAllowDiscrete(),
         transition->getProperties());
 
-    LOG(INFO) << "changedPropertyNames: "
-              << changedProps.changedPropertyNames.size();
-    for (const auto &propName : changedProps.changedPropertyNames) {
-      LOG(INFO) << "changedPropertyNames: " << propName;
-    }
-
-    LOG(INFO) << "oldProps changedProps: "
-              << stringifyJSIValue(rt, changedProps.oldProps);
-    LOG(INFO) << "newProps changedProps: "
-              << stringifyJSIValue(rt, changedProps.newProps);
-
     if (changedProps.changedPropertyNames.empty()) {
       return;
     }

diff --git a/...eact-native-reanimated/src/css/platform/native/style/processors/__tests__/shadows.test.ts b/...eact-native-reanimated/src/css/platform/native/style/processors/__tests__/shadows.test.ts
@@ -1,3 +1,16 @@
 import { processBoxShadow } from '../shadows';
 
-describe(processBoxShadow, () => {});
+describe(processBoxShadow, () => {
+  describe('returns a correct number of shadows', () => {
+    it('returns a correct number of shadows', () => {
+      expect(processBoxShadow('0 0 10px 0 red, 0 0 20px 0 blue')).toEqual([
+        {
+          offsetX: 0,
+          offsetY: 0,
+          blurRadius: 10,
+          color: 'red',
+        },
+      ]);
+    });
+  });
+});