Skip to content

Commit

Permalink
fix: restore classic runtime for @babel/preset-react (#6760)
Browse files Browse the repository at this point in the history
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Fixes
#6665

Applying the change I made to `react-native-builder-bob`:
- callstack/react-native-builder-bob#695

It restores `classic` runtime for the `@babel/react-native` preset used
for generating ESModule code. The behavior was changed when we bumped
builder-bob:
- #6485


## Test plan

I ran the `diff` for the version of `lib` without `jsxRuntime: classic`
and with it - the differences are only in regards to `_jsx` usage. You
can read more here:
-
#6665
  • Loading branch information
tjzel committed Dec 13, 2024
1 parent ea6c7b8 commit 67a7c45
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
5 changes: 3 additions & 2 deletions packages/react-native-reanimated/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
"prettier": "^3.3.3",
"react": "18.3.1",
"react-native": "^0.76.1",
"react-native-builder-bob": "0.30.2",
"react-native-builder-bob": "0.33.1",
"react-native-gesture-handler": "2.20.2",
"react-native-web": "0.19.11",
"react-test-renderer": "18.2.0",
Expand All @@ -158,7 +158,8 @@
[
"module",
{
"esm": true
"esm": true,
"jsxRuntime": "classic"
}
],
"typescript"
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17688,9 +17688,9 @@ __metadata:
languageName: node
linkType: hard

"react-native-builder-bob@npm:0.30.2":
version: 0.30.2
resolution: "react-native-builder-bob@npm:0.30.2"
"react-native-builder-bob@npm:0.33.1":
version: 0.33.1
resolution: "react-native-builder-bob@npm:0.33.1"
dependencies:
"@babel/core": "npm:^7.25.2"
"@babel/plugin-transform-strict-mode": "npm:^7.24.7"
Expand All @@ -17716,7 +17716,7 @@ __metadata:
yargs: "npm:^17.5.1"
bin:
bob: bin/bob
checksum: 10/0a6f2321ce7ba4aa08a40e5d599c94fe4705afc7d67ac9d4e2400603dd91cfa6646afdc02697ff683dca3b2654b1701bab4114c3548f4dfa0c9327a74a8a8a48
checksum: 10/c4aaefdc1f82a88ce66c5b448ed851213ca614c777a775cb0772ab80e75852761b915d715ed6f58f99670b1b2fba6435e1d9c03445b9ba8eb44befeb77f5b532
languageName: node
linkType: hard

Expand Down Expand Up @@ -17877,7 +17877,7 @@ __metadata:
prettier: "npm:^3.3.3"
react: "npm:18.3.1"
react-native: "npm:^0.76.1"
react-native-builder-bob: "npm:0.30.2"
react-native-builder-bob: "npm:0.33.1"
react-native-gesture-handler: "npm:2.20.2"
react-native-web: "npm:0.19.11"
react-test-renderer: "npm:18.2.0"
Expand Down

0 comments on commit 67a7c45

Please sign in to comment.