fix: Installation of Reanimated from commit on CI (#6635)

## Summary Turns out installing from commit didn't work well and CI often times didn't check what it was supposed to test. Failing V8 CI is good now, since it fails on actual compilation steps. ## Test plan 🚀
software-mansion · Oct 29, 2024 · 651bb21 · 651bb21
1 parent 254a737
commit 651bb21
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 22 deletions.
diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml
@@ -18,6 +18,9 @@ jobs:
     concurrency:
       group: build-v8-${{ github.ref }}
       cancel-in-progress: true
+    env:
+      APP_NAME: app
+      LATEST_SUPPORTED_RN_VERSION_IN_V8: 0.75
     steps:
       - name: Check out
         uses: actions/checkout@v4
@@ -28,19 +31,30 @@ jobs:
         with:
           distribution: 'zulu'
           java-version: '17'
-      - name: Create React Native app
-        run: npx react-native init app
+      - name:
+          Setup Yarn
+          # Sometimes `npx react-native init` fails due to dependency mismatches or other
+          # rather vague errors. This is a workaround for that.
+        run: corepack enable && yarn init
+      - name: Install React Native
+        run: yarn add react-native
+      - name: Create app
+        run: |
+          yarn react-native init ${{ env.APP_NAME }} --version ${{env.LATEST_SUPPORTED_RN_VERSION_IN_V8}} --skip-install --pm yarn --skip-install --install-pods false --skip-git-init
+      - name: Setup Yarn Modern
+        working-directory: ${{ env.APP_NAME }}
+        run: touch yarn.lock && yarn set version berry && yarn config set nodeLinker node-modules
       - name: Install dependencies
-        working-directory: app
+        working-directory: ${{ env.APP_NAME }}
         run: yarn install
       - name: Install Reanimated
-        working-directory: app
-        run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }}
+        working-directory: ${{ env.APP_NAME }}
+        run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
       - name: Install test dependencies
-        working-directory: app
+        working-directory: ${{ env.APP_NAME }}
         run: yarn add react-native-v8 v8-android-jit
       - name: Configure V8
         run: node reanimated_repo/.github/workflows/helper/configureV8.js
-      - name: Build Android app
-        working-directory: app/android
+      - name: Build Android
+        working-directory: ${{ env.APP_NAME }}/android
         run: ./gradlew assembleDebug --console=plain
diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml
@@ -1,6 +1,6 @@
 name: React Native nightly Reanimated build check [Nightly]
 env:
-  YARN_ENABLE_HARDENED_MODE: 0
+  YARN_ENABLE_IMMUTABLE_INSTALLS: 0
 on:
   pull_request:
     paths:
@@ -46,19 +46,19 @@ jobs:
       - name: Create app
         run: |
           yarn react-native init ${{ env.APP_NAME }} --version ${{ env.REACT_NATIVE_TAG }} --pm yarn --skip-install --install-pods false --skip-git-init
-      - name: Add yarn.lock in app
+      - name: Setup Yarn Modern
         working-directory: ${{ env.APP_NAME }}
-        run: touch yarn.lock
+        run: touch yarn.lock && yarn set version berry
       - name: Install Reanimated
         working-directory: ${{ env.APP_NAME }}
-        run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }}
+        run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
       - name: Install Paper Pods (iOS)
         if: ${{ matrix.react-native-architecture == 'Paper' && matrix.platform == 'iOS' }}
-        working-directory: app/ios
+        working-directory: ${{ env.APP_NAME }}/ios
         run: bundle install && bundle exec pod install
       - name: Install Fabric Pods (iOS)
         if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'iOS' }}
-        working-directory: app/ios
+        working-directory: ${{ env.APP_NAME }}/ios
         run: RCT_NEW_ARCH_ENABLED=1 bundle install && bundle exec pod install
       - name: Setup Fabric (Android)
         if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'Android' }}

diff --git a/.github/workflows/reanimated-compatibility-check-nightly.yml b/.github/workflows/reanimated-compatibility-check-nightly.yml
@@ -53,7 +53,7 @@ jobs:
         run: corepack enable && yarn set version berry
       - name: Install Reanimated
         working-directory: ${{ env.APP_NAME }}
-        run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }}
+        run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
       - name: Install Pods
         if: ${{ matrix.platform == 'iOS' }}
         working-directory: ${{ env.APP_NAME }}/ios

diff --git a/.github/workflows/static-framework-reanimated-build-check-nightly.yml b/.github/workflows/static-framework-reanimated-build-check-nightly.yml
@@ -26,7 +26,7 @@ jobs:
         run: npx react-native init app
       - name: Install Reanimated
         working-directory: app
-        run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }}
+        run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
       - name: Install Paper Pods
         if: ${{ matrix.react-native-architecture == 'Paper' }}
         working-directory: app/ios

diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml
@@ -17,20 +17,31 @@ jobs:
     concurrency:
       group: build-on-windows-${{ github.ref }}
       cancel-in-progress: true
+    env:
+      APP_NAME: app
     steps:
       - name: Set up JDK 17
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
           java-version: '17'
-      - name: Create React Native App
-        run: npx react-native init app
+      - name: Setup Yarn
+        # Sometimes `npx react-native init` fails due to dependency mismatches or other
+        # rather vague errors. This is a workaround for that.
+        run: corepack enable && yarn init --yes
+      - name: Install React Native
+        run: yarn add @react-native-community/cli
+      - name: Create app
+        run: yarn rnc-cli init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init
+      - name: Setup Yarn Modern
+        working-directory: ${{ env.APP_NAME }}
+        run: touch yarn.lock && yarn set version berry
       - name: Install dependencies
-        working-directory: app
+        working-directory: ${{ env.APP_NAME }}
         run: yarn
       - name: Install Reanimated
-        working-directory: app
-        run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }}
+        working-directory: ${{ env.APP_NAME }}
+        run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
       - name: Build Android App
-        working-directory: app/android
+        working-directory: ${{ env.APP_NAME }}/android
         run: ./gradlew assembleDebug --console=plain