Skip to content

Commit

Permalink
Fix slow animation on iOS (#6954)
Browse files Browse the repository at this point in the history
## Summary

This PR adds the missing call to `calculateTimestampWithSlowAnimations`,
which is necessary to properly handle slow animations on iOS.

| before | after |
| --- | --- |
| <video
src="https://github.com/user-attachments/assets/e09f3e50-5a12-472d-aea1-71d98c1638bb"
/> | <video
src="https://github.com/user-attachments/assets/d3a6d047-d443-4f3b-9947-b6f96ee9d479"
/> |

## Test plan

Runa animation and toggle slow animation on iOS.
  • Loading branch information
piaskowyk authored Jan 30, 2025
1 parent 953bd61 commit 18b65cb
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,7 @@ RequestRenderFunction makeRequestRender(REANodesManager *nodesManager)
// TODO macOS targetTimestamp isn't available on macOS
auto targetTimestamp = displayLink.timestamp + displayLink.duration;
#endif
double frameTimestamp =

(targetTimestamp) * 1000;
const double frameTimestamp = calculateTimestampWithSlowAnimations(targetTimestamp) * 1000;
onRender(frameTimestamp);
}];
};
Expand Down

0 comments on commit 18b65cb

Please sign in to comment.