implement rippleRadius for TouchableNativeFeedback #1069
Merged
+58
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
commented
May 19, 2020
| public void setBorderRadius(float borderRadius) { | ||
| mBorderRadius = borderRadius * (float)getResources().getDisplayMetrics().density; |
There was a problem hiding this comment.
the float cast was not needed
vonovak
commented
May 19, 2020
| mNeedBackgroundUpdate = true; | ||
| } | ||
|
|
||
| private Drawable applyRippleEffectWhenNeeded(Drawable selectable) { | ||
| if (mRippleColor != null | ||
| && selectable != null |
There was a problem hiding this comment.
selectable != null is covered by selectable instanceof RippleDrawable
kmagiera
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
The code looks good. Thanks for this @vonovak! I'll let @jakub-gonet do the final call here and merge this
jakub-gonet
requested changes
Jul 7, 2020
android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.java
Outdated
Show resolved
Hide resolved
|
@jakub-gonet any plans for a new release? Thank you! |
|
After gathering few more PRs we'll release the next version. Thanks for contributing 🎉 |
braincore
pushed a commit
to braincore/react-native-gesture-handler
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! this is a combination of
facebook/react-native#28600 and facebook/react-native#28009
please let me know if you need any extra information, thank you!