update to hyper v0.10 with separate openssl dependency #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abronan
commented
Jan 15, 2017
| @@ -12,17 +12,15 @@ license = "MIT" | |||
|
|
|||
| [dependencies] | |||
| flate2 = "0.2" | |||
| hyperlocal = "0.2" | |||
| hyperlocal = { git = "https://github.com/abronan/hyperlocal.git", branch = "update_hyper" } | |||
There was a problem hiding this comment.
Will update this dependency (which currently points to my fork) if a new version is tagged or to the master branch of the main repository :)
abronan
commented
Jan 16, 2017
| @@ -12,17 +12,15 @@ license = "MIT" | |||
|
|
|||
| [dependencies] | |||
| flate2 = "0.2" | |||
| hyperlocal = "0.2" | |||
| hyperlocal = "0.3" | |||
There was a problem hiding this comment.
Thanks for bumping the version! Updated :)
|
Going to merge this but before I cut the next release I may experiment with hyper native tls which supposedly works a bit more seamlessly. Thanks again for moving hyper upgrade process forward! |
|
Oh wait gh is telling me theres merge conflicts. Can you merge the latest and push. Happy to merge then |
Signed-off-by: Alexandre Beslic <[email protected]>
|
Whoops indeed, just rebased :) |
|
Thanks @abronan! |
|
@softprops Thanks to you for putting effort into the lib :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR updates the
hypercrate tov0.10which removes the dependency toopenssl. TLS support is added through thehyper-opensslcrate.This depends on softprops/hyperlocal#5 which also updates
hyperlocaltov0.10to avoid a clash withopenssl-sysversions.Some context here: hyperium/hyper#985
Signed-off-by: Alexandre Beslic [email protected]