Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soap transport #1626

Merged
merged 9 commits into from
May 10, 2022
Merged

Conversation

allmightyspiff
Copy link
Member

@allmightyspiff allmightyspiff commented Apr 27, 2022

This adds an experimental Soap transport. It also refactors the other transports a bit so that they are not in a single file anymore.

Fixes #1602

TESTING

Since this change moves around some core files, I'm mostly interested in making sure 3rd party scripts continue to work fine. So to test this just take a script from https://sldn.softlayer.com/python/ and make sure it still runs as expected.

The SOAP Transport itself wont work out of the box quite yet, which is expected. At this point I just want to make sure I'm not breaking anything existing.

@edsonarios
Copy link
Contributor

Test
Account, getObject
image

Virtual_Guest, getObject
image

Virtual_Guest, editObject
image

Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit 06cd4ae into softlayer:master May 10, 2022
@allmightyspiff allmightyspiff deleted the soapTransport branch May 10, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Investigate adding a SOAP transport
3 participants