-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soap transport #1626
Merged
allmightyspiff
merged 9 commits into
softlayer:master
from
allmightyspiff:soapTransport
May 10, 2022
Merged
Soap transport #1626
allmightyspiff
merged 9 commits into
softlayer:master
from
allmightyspiff:soapTransport
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings. Need to figure out how to deal with href entries though
edsonarios
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an experimental Soap transport. It also refactors the other transports a bit so that they are not in a single file anymore.
Fixes #1602
TESTING
Since this change moves around some core files, I'm mostly interested in making sure 3rd party scripts continue to work fine. So to test this just take a script from https://sldn.softlayer.com/python/ and make sure it still runs as expected.
The SOAP Transport itself wont work out of the box quite yet, which is expected. At this point I just want to make sure I'm not breaking anything existing.