Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopGauge prevent NoopId #29

Closed
luyiisme opened this issue Jul 17, 2018 · 0 comments · Fixed by #34
Closed

TopGauge prevent NoopId #29

luyiisme opened this issue Jul 17, 2018 · 0 comments · Fixed by #34

Comments

@luyiisme
Copy link
Contributor

Describe the bug

A Noop MetricId will cause metric type cast err.

Expected behavior

Actual behavior

ignore noopId, do not register it .

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • SOFALookout version: 1.4.*
  • JVM version (e.g. java -version): 1.8
  • OS version (e.g. uname -a): -
  • Maven version: 3.2.5
  • IDE version: -
@luyiisme luyiisme mentioned this issue Aug 27, 2018
Merged
luyiisme added a commit that referenced this issue Aug 30, 2018
@luyiisme
被动采集功能重构&若干问题修复 (#34)
77b691c 
* #29 TopGauge prevent NoopId
* add linux os metrics export
* lookoutRegistry (support proactive mode) and add access token ctrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

被动采集功能重构&若干问题修复
1 participant
@luyiisme