This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13 from ThibG/httprb
Add (failing) http.rb wrap test for TCPSocket and SSLSocket
- Loading branch information
Showing
2 changed files
with
87 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,4 +19,6 @@ group :test do | |
gem 'coveralls', require: false | ||
|
||
gem 'async-container' | ||
|
||
gem 'http' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
# Copyright, 2018, by Thibaut Girka | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in | ||
# all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
# THE SOFTWARE. | ||
|
||
require 'http' | ||
require 'openssl' | ||
|
||
require 'async/io/tcp_socket' | ||
require 'async/io/ssl_socket' | ||
|
||
# There are different ways to achieve this. This is really just a proof of concept. | ||
module Wrap | ||
module TCPSocket | ||
def self.new(*args) | ||
if Async::Task.current? | ||
Async::IO::TCPSocket.new(*args) | ||
else | ||
::TCPSocket.new(*args) | ||
end | ||
end | ||
|
||
def self.open(*args) | ||
self.new(*args) | ||
end | ||
end | ||
|
||
module SSLSocket | ||
def self.new(*args) | ||
if Async::Task.current? | ||
# wrap instead of new | ||
Async::IO::SSLSocket.wrap(*args) | ||
else | ||
OpenSSL::SSL::SSLSocket.new(*args) | ||
end | ||
end | ||
end | ||
end | ||
|
||
RSpec.describe Async::IO::TCPSocket do | ||
describe "inside reactor" do | ||
include_context Async::RSpec::Reactor | ||
|
||
it "should fetch page" do | ||
expect(Async::IO::TCPSocket).to receive(:new).and_call_original | ||
|
||
expect do | ||
response = HTTP.get('https://www.google.com', { socket_class: Wrap::TCPSocket, ssl_socket_class: Wrap::SSLSocket }) | ||
response.connection.close | ||
end.to_not raise_error | ||
end | ||
|
||
it "should fetch page when used as a drop-in replacement" do | ||
expect(Async::IO::TCPSocket).to receive(:new).and_call_original | ||
response = HTTP.get('https://www.google.com', { socket_class: Async::IO::TCPSocket, ssl_socket_class: Async::IO::SSLSocket }) | ||
response.connection.close | ||
expect do | ||
end.to_not raise_error | ||
end | ||
end | ||
|
||
describe "outside reactor" do | ||
it "should fetch page" do | ||
expect do | ||
response = HTTP.get('https://www.google.com', { socket_class: Wrap::TCPSocket, ssl_socket_class: Wrap::SSLSocket }) | ||
response.connection.close | ||
end.to_not raise_error | ||
end | ||
end | ||
end |