Prefer frozen empty string.

socketry · Jan 28, 2025 · 546dec9 · 546dec9
1 parent 08051c3
commit 546dec9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/async/http/faraday/adapter.rb b/lib/async/http/faraday/adapter.rb
@@ -241,7 +241,7 @@ def with_timeout(task: Async::Task.current)
 
 				def encoded_body(response)
 					body = response.read
-					return +"" if body.nil?
+					return "" if body.nil?
 					content_type = response.headers["content-type"]
 					return body unless content_type
 					params = extract_type_parameters(content_type)

diff --git a/test/async/http/faraday/adapter.rb b/test/async/http/faraday/adapter.rb
@@ -103,7 +103,6 @@ def get_response(url = bound_url, path = "/index", adapter_options: {})
 
 			it "properly handles no content responses" do
 				expect(get_response.body).to be == ""
-				expect(get_response.body).not.to be(:frozen?)
 			end
 		end
-Original file line number
+Diff line change
@@ Expand Up @@
     			it "properly handles no content responses" do
     				expect(get_response.body).to be == ""
-    				expect(get_response.body).not.to be(:frozen?)
     			end
     		end
@@ Expand Down @@