Socket.io dies (uncatchable) on faulty web socket connection

[cramforce]

Streamie.org was crashing constantly with a message that in line 23 of websocket.js this.connection did not have a method of "setTimeout"

Because this was the production system I added a line
if(!this.connection.setTimeout) return;

This works around the server-crash issue for me.

I now get this constantly
3 Sep 14:31:07 - Initializing client with transport "websocket"
3 Sep 14:31:07 - WebSocket connection invalid

I suspect a faulty client is reconnecting all the time.

[rauchg]

Fix for certain buggy clients. Needs more investigation. Thanks Malte Ubl (@cramforce) for the report. Closed by 701c35d

[dshaw]

Still getting this in 0.5.3.

Here's a copy of the error:
/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/transports/websocket.js:23
this.connection.setTimeout(0);
^
TypeError: Object # has no method 'setTimeout'
at [object Object]._onConnect (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/transports/websocket.js:23:18)
at [object Object]. (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/client.js:17:7)
at new (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/transports/websocket.js:7:9)
at [object Object]._onConnection (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/listener.js:123:73)
at [object Object].check (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/listener.js:83:9)
at Server. (/home/mediadesign/lib/node/.npm/socket.io/0.5.3/package/lib/socket.io/listener.js:39:12)
at Server.emit (events:27:15)
at HTTPParser.onIncoming (http:831:10)
at HTTPParser.onHeadersComplete (http:87:31)
at Stream.ondata (http:763:22)

[dshaw]

FWIW, http://github.com/dshaw/canisocket/ is running with @miksago's node-websocket-server without issue. http://canisocket.com/

Perhaps that will help triangulate the issue.

[rauchg]

It was fixed in master

[dshaw]

Great, thanks Guillermo. Switched to master and http://github.com/dshaw/remoteconsole is working great.