Skip to content

Commit

Permalink
chore: move ws from peerDependencies to dependencies
Browse files Browse the repository at this point in the history
In order to prevent issues like [1].

Note: the version matches the one imported by the `engine.io` package

See: https://github.com/socketio/engine.io/blob/6.3.0/package.json#L43

[1]: socketio/socket.io-redis-adapter#478
  • Loading branch information
darrachequesne committed Jan 12, 2023
1 parent 4e3991f commit ca39942
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
12 changes: 5 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
"description": "default socket.io in-memory adapter",
"peerDependencies": {
"ws": "*"
"dependencies": {
"ws": "~8.11.0"
},
"devDependencies": {
"@types/mocha": "^10.0.1",
Expand Down

0 comments on commit ca39942

Please sign in to comment.