Chore: Bump ws version to ~3.3.1 #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously ~2.3.1; Bumped due to potential DOS issue. See here: https://nodesecurity.io/advisories/550 There were some breaking changes in v3.0.0, however they don't seem to affect anything here. That being said, someone who's more familiar should probably take another look. Breaking changes are seen here: https://github.com/websockets/ws/releases/tag/3.0.0
|
Thanks! |
|
Thanks @darrachequesne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
N/A
New behaviour
N/A
Other information (e.g. related issues)
Was previously ~2.3.1; Bumped due to potential DOS issue. See here: https://nodesecurity.io/advisories/550
There were some breaking changes in v3.0.0, however they don't seem to affect anything here. That being said, someone who's more familiar should probably take another look. Breaking changes are seen here: https://github.com/websockets/ws/releases/tag/3.0.0