Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Add ClassInfo.initializer to object.di #37

Conversation

nemanja-boric-sociomantic
Copy link
Contributor

This method was added to object_.d and it should be present
in the accompanying di file.

This method was added to object_.d and it should be present
in the accompanying di file.
@leandro-lucarella-sociomantic
Copy link
Contributor

Is there any easy way to reproduce the problem and add an unittest for it to avoid some inconsistency like this to happen again?

@nemanja-boric-sociomantic
Copy link
Contributor Author

It's super easy to test if you have a binary that was built against this di file but linked against the library with the different object.d. I'm not sure how to pull that off with the unittest (I don't think it's possible).

I could add turtle test and make makd link in the built library, but I think that would be overkill, as it would still protect you just from this particular field discrepancy. I think the safer way is just to put libtangort in support-only mode for the rest of the transition time.

@leandro-lucarella-sociomantic
Copy link
Contributor

Let's merge as is then, tangort will hopefully die soon enough anyway!

@leandro-lucarella-sociomantic leandro-lucarella-sociomantic merged commit ead8e79 into sociomantic-tsunami:v1.9.x Jun 20, 2018
@mathias-baumann-sociomantic

Well, maybe not as unittest, but it should be simple enough with some makefile additions?

@nemanja-boric-sociomantic
Copy link
Contributor Author

Maybe. We had to push this ASAP when we released v1.9.0 (it was causing a segfault in all turtle tests). Still, I think it's better to stop putting new features here (we had this one in, what, two years?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants