Switch in contracts to verify in core
#255
Conversation
mihails-strasuns-sociomantic
force-pushed
the
verify-core
branch
from
2b8420d to
f83a588
Compare
Codecov Report
@@ Coverage Diff @@
## v3.x.x #255 +/- ##
==========================================
- Coverage 72% 71.99% -0.01%
==========================================
Files 458 458
Lines 38855 38857 +2
==========================================
- Hits 27979 27977 -2
- Misses 10876 10880 +4 |
mihails-strasuns-sociomantic
requested review from
gavin-norman-sociomantic and
nemanja-boric-sociomantic
|
Ping :) |
src/ocean/core/Enum.d
Outdated
| import ocean.transition; | ||
|
|
||
| import ocean.core.Test; |
There was a problem hiding this comment.
This should be another commit, but I don't think it matters much, up to you.
| @@ -103,7 +104,7 @@ struct ByteSwap | |||
|
|
|||
| final static void swap16 (void *dst, size_t bytes) | |||
| { | |||
| assert ((bytes & 0x01) is 0); | |||
| verify((bytes & 0x01) is 0); | |||
There was a problem hiding this comment.
The commit message isn't really true. This commit alters more than just "in contracts".
| // Internal name/value lists | ||
| assert(E.names == names); | ||
| assert(E.values == values); | ||
| test(names.length == values.length); |
There was a problem hiding this comment.
Separate commit for this?
| @@ -483,6 +470,11 @@ class MessageFiber | |||
| } | |||
| body | |||
| { | |||
| verify( | |||
There was a problem hiding this comment.
This is a very important one! 👍
src/ocean/core/SmartEnum.d
Outdated
| @@ -111,19 +111,13 @@ | |||
|
|
|||
| module ocean.core.SmartEnum; | |||
|
|
|||
|
|
|||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Why all the mixed in formatting changes? :(
There was a problem hiding this comment.
Because I couldn't decide where to put new import without it 
There was a problem hiding this comment.
Hmm... I don't see the relation.
mihails-strasuns-sociomantic
force-pushed
the
verify-core
branch
from
f83a588 to
9945784
Compare
|
Updated with test changes split into separate commit |
mihails-strasuns-sociomantic
force-pushed
the
verify-core
branch
from
9945784 to
bc6cd4b
Compare
|
Rebased |
No description provided.