Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocean must pass tests when run with -release #96

Closed
mihails-strasuns-sociomantic opened this issue May 2, 2017 · 3 comments
Closed

Ocean must pass tests when run with -release #96

mihails-strasuns-sociomantic opened this issue May 2, 2017 · 3 comments
Labels
type-breaking type-refactoring
Milestone
v4.0.0

Comments

@mihails-strasuns-sociomantic
Copy link
Contributor

Essentially another form of the goal to clean up assert usage in ocean to make -release flag feasible for our applications. Right now it doesn't even pass tests because some failed assertions are checked with testThrown.
@mihails-strasuns-sociomantic mihails-strasuns-sociomantic added this to the v4.0.0 milestone May 2, 2017
@mihails-strasuns-sociomantic
Copy link
Contributor Author

For the reference, the one failure I noticed was ./src/ocean/core/SmartUnion.d:139: test error: Expected 'Exception' to be thrown, but it wasn't

Closed
@nemanja-boric-sociomantic
Copy link
Contributor

For the reference, I think the problem with the SmartUnion isn't the assert vs enforce, but in contract: https://github.com/sociomantic-tsunami/ocean/blob/v3.x.x/src/ocean/core/SmartUnion.d#L506

@mihails-strasuns-sociomantic
Copy link
Contributor Author

contract == assert

nemanja-boric-sociomantic added a commit to nemanja-boric-sociomantic/ocean-1 that referenced this issue Sep 5, 2017
@nemanja-boric-sociomantic
Move the SmartUnion's active member enforcement into method body
0ccd8e8 
The enforcement which was used to confirm that the active member
has been accessed was omitted in the `-release` build. Now it's moved
in the method's body and it still active, no matter if compiled with
`-release`.

Fixes sociomantic-tsunami#96
Merged
mihails-strasuns-sociomantic pushed a commit that referenced this issue Sep 5, 2017
@nemanja-boric-sociomantic @mihails-strasuns-sociomantic
Move the SmartUnion's active member enforcement into method body
42d74eb 
The enforcement which was used to confirm that the active member
has been accessed was omitted in the `-release` build. Now it's moved
in the method's body and it still active, no matter if compiled with
`-release`.

Fixes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-breaking type-refactoring
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@mihails-strasuns-sociomantic @nemanja-boric-sociomantic