fix: correctly parse dverbose test scope dependency management #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotkas
reviewed
Aug 8, 2024
dotkas
approved these changes
Aug 8, 2024
orsagie
force-pushed
the
fix/test-scope-dependency-management
branch
18 times, most recently
from
9be20f7 to
01bb9f6
Compare
orsagie
force-pushed
the
fix/test-scope-dependency-management
branch
from
01bb9f6 to
5d411ab
Compare
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a pom brings in a dependency that is managed by a parent with dependencyManagement and the --Dverbose flag is used - the plugin would not show the correct dependencies. This fixes the issue.
Where should the reviewer start?
Look at the test pom and run the tests
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions