Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unit tests if API key is missing #98

Closed
mzuehlke opened this issue Oct 28, 2018 · 0 comments · Fixed by #99
Closed

Skip unit tests if API key is missing #98

mzuehlke opened this issue Oct 28, 2018 · 0 comments · Fixed by #99
Milestone
Version 0.5.0

Comments

@mzuehlke
Copy link
Contributor

Library version: 0.4.0

Expected behavior:
IF the DarkSky or OpenWeatherMap API keys are not given the respective unit test should be skipped.

Actual behavior: The unit tests are failing.

Steps to reproduce: Execute unit test without an API key.

I recognized this while working on #97
@mzuehlke mzuehlke mentioned this issue Oct 28, 2018
Merged
@BenFradet BenFradet changed the title Skip unit test, if API is missing Skip unit tests if API key is missing Oct 29, 2018
BenFradet pushed a commit that referenced this issue Oct 29, 2018
@mzuehlke @BenFradet
Skip unit tests if API key is missing (closes #98)
1dd0707
@dilyand dilyand added this to the 0.5.0 milestone Nov 27, 2019
dilyand pushed a commit that referenced this issue Nov 27, 2019
@mzuehlke @dilyand
Skip unit tests if API key is missing (closes #98)
81e21bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.5.0
Development

Successfully merging a pull request may close this issue.

Skip unit test, if no API is is given instead of failing. mzuehlke/scala-weather
2 participants
@mzuehlke @dilyand