Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Update the contributor notes with instructions about ast.proto #3005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-oplaton
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-0.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Mention ast.proto in the contributor notes, add instructions for keeping ast_pb2.py up to date, and enumerate the packages required for development.

@sfc-gh-oplaton sfc-gh-oplaton added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Feb 12, 2025
@sfc-gh-oplaton sfc-gh-oplaton marked this pull request as ready for review February 12, 2025 19:27
@sfc-gh-oplaton sfc-gh-oplaton requested review from a team as code owners February 12, 2025 19:27
@sfc-gh-oplaton sfc-gh-oplaton enabled auto-merge (squash) February 12, 2025 19:27
auto-merge was automatically disabled February 13, 2025 22:52

Pull request was closed

@sfc-gh-yuwang sfc-gh-yuwang deleted the oplaton/snowpark-contributing branch February 13, 2025 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@sfc-gh-oplaton sfc-gh-oplaton restored the oplaton/snowpark-contributing branch February 13, 2025 23:04
@sfc-gh-oplaton sfc-gh-oplaton enabled auto-merge (squash) February 24, 2025 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants