-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1794377: Add support for Dataframe.toJSON #2774
Merged
sfc-gh-jrose
merged 6 commits into
SNOW-1830033-dataframe-api-bcrs
from
jrose_snow_1794377_dataframe_tojson_support
Dec 20, 2024
Merged
SNOW-1794377: Add support for Dataframe.toJSON #2774
sfc-gh-jrose
merged 6 commits into
SNOW-1830033-dataframe-api-bcrs
from
jrose_snow_1794377_dataframe_tojson_support
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also should update the dataframe.rst file
c68883f
to
9a16be6
Compare
sfc-gh-aalam
approved these changes
Dec 20, 2024
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
8b81bd8
to
e0a7435
Compare
0d47fb6
into
SNOW-1830033-dataframe-api-bcrs
36 of 37 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1794377
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds an approximation of pysparks Dataframe.toJSON method. Notably Snowpark does not support RDDs so instead we return a Dataframe. Additionally Snowflake JSON methods don't support the
use_unicode
flag that pyspark provides so that is left out as well. We could add it as a dummy value for compatibility, but I think we should stick to what the Snowflake API can provide.