Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-977206 Fix testPreparedStatement #1569

Merged
merged 1 commit into from
Nov 28, 2023
Merged

SNOW-977206 Fix testPreparedStatement #1569

merged 1 commit into from
Nov 28, 2023

Conversation

sfc-gh-pfus
Copy link
Contributor

@sfc-gh-pfus sfc-gh-pfus commented Nov 24, 2023 •
edited
Loading

Overview

SNOW-977206 Fix testPreparedStatement
When use database was called, the schema was switched to public. When the same test was run on multiple parallel builds, they possibly use the same table in the same time.

Also fixed resource management in this test class.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-977206-testPreparedStatement branch 7 times, most recently from d95dd4b to e89aa52 Compare November 24, 2023 12:57
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review November 24, 2023 13:18
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 24, 2023 13:18
@sfc-gh-pfus sfc-gh-pfus changed the title SNOW-977206 Add more logging to testPreparedStatement SNOW-977206 Fix testPreparedStatement Nov 24, 2023
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-977206-testPreparedStatement branch from e89aa52 to 02f62e4 Compare November 27, 2023 07:03
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-977206-testPreparedStatement branch from 02f62e4 to b7affa2 Compare November 27, 2023 07:09
@sonarqubemergegate SonarQubeMergeGate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sfc-gh-igarish
sfc-gh-igarish approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 4db5434 into master Nov 28, 2023
24 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-977206-testPreparedStatement branch November 28, 2023 06:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz