Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
fix(CommandRegistryHandler): updates even without difference
Browse files Browse the repository at this point in the history
  • Loading branch information
ijsKoud committed Dec 3, 2022
1 parent 81f5086 commit 0faa1a0
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions src/handlers/CommandRegistryHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,8 @@ export class CommandRegistry {
* @param command the bot Command
*/
private isDifferent(discord: ApplicationCommand, command: Command): string | null {
// @ts-ignore Re-assigning value to make sure Lodash does not return false when checking
discord.nameLocalizations ??= undefined;

if (!_.isEqual(discord.nameLocalizations, command.nameLocalizations)) return "nameLocalizations";
if (!_.isEqual(discord.descriptionLocalizations, command.descriptions)) return "descriptionLocalizations";
if (!_.isEqual(discord.nameLocalizations, command.nameLocalizations ?? null)) return "nameLocalizations";
if (!_.isEqual(discord.descriptionLocalizations, command.descriptions ?? null)) return "descriptionLocalizations";
if (discord.description !== command.description) return "description";

if (discord.dmPermission !== command.permissions.dm) return "dmPermission";
Expand Down Expand Up @@ -182,10 +179,8 @@ export class CommandRegistry {
// Expected DiscordOption but received undefined
if (!discord) return "undefined";

// Re-assigning nameLocalizations value to undefined if value is null
discord.nameLocalizations ??= undefined;
// check the name localizations
if (!_.isEqual(discord.nameLocalizations, command.nameLocalizations)) return "nameLocalizations";

// check the description localizations
if (!_.isEqual(discord.descriptionLocalizations, command.descriptionLocalizations)) return "descriptionLocalizations";
// check the description
Expand Down Expand Up @@ -277,8 +272,8 @@ export class CommandRegistry {
private getCommandData(command: Command): ApplicationCommandData {
return {
name: command.name,
nameLocalizations: command.nameLocalizations ?? {},
description: command.description,
nameLocalizations: command.nameLocalizations ?? {},
descriptionLocalizations: command.descriptions ?? {},
dmPermission: command.permissions.dm,
defaultMemberPermissions: command.permissions.default ? new PermissionsBitField(command.permissions.default) : null,
Expand Down

0 comments on commit 0faa1a0

Please sign in to comment.