Fixing flaky test #1671
Merged
Fixing flaky test #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@crawlingcub thanks for the contribution--and sorry for the delay here. I've confirmed this works as you described am ok to merge if that's ok with you! |
fpoms
approved these changes
Apr 7, 2022
|
@crawlingcub if you could rebase onto main, and the tests pass, then I can merge this. |
|
hi i merged master. can you merge? |
|
Merged! Thanks @crawlingcub ! |
akode
pushed a commit
to akode/snorkel
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_labeling_convergenceintest/labeling/test_convergence.pysometimes fails when the seed settings are removed. It failed 52 out of 500 runs times for me on my machine. Updating the assertion threshold to0.06ensures that the test always passes (even without seeds). For obtaining this solution, I analyzed the underlying tail distribution of theerrvariable and computed the 99.99th percentile. This provided an estimate of~0.0555. I rounded up the value in the assertion to fix the test.I think the seed settings on lines 61-63 can also be removed since this class only has one test. I can remove them if you agree with this change.
Please let me know if this change looks reasonable. I will be happy to incorporate any other suggestions that you may have.
Thanks!