Fixed: Asset Count on Users Index Page Counting Soft Deleted Items

[akemidx]

This more robustly tallies the assets count on the users index page. Soft deleted assets could still show in the created table under certain circumstances.

old:

new:

Fixes: 27551

[what-the-diff]

PR Summary

• Inclusion of Builder Import
  The update brings in a specific tool known as Builder to enhance the code. This tool is part of a package called Illuminate\Database\Eloquent\Builder and is crucial for managing more advanced database operations with ease.

• Adjustments to withCount Method
  The changes have made the withCount method more flexible and efficient. This function, which is used to count certain items in the application, now uses an array format. Additionally, it incorporates a custom query for excluding assets that are no longer in use or 'trashed', improving the accuracy of our counts.

[snipe]

I think we'd probably want to modify the assets method to not use withTrashed() versus this approach, no?

[akemidx]

We could, but the hesitation with that was what else around the site would that alter?
There are probably a few other places that asset count is used, and we could doink up a count that should include withTrashed()

[akemidx]

coming back to this.

I personally think we shouldn't modify the method. Doing so would make us have to go to each place we call the method and edit those to use withTrashed() or withoutTrashed()

That is a tone of work for a smaller fix like this, and leaves us the possiblity of missing one or two and adding on more work in the future. I don't disagree with you tho, in that these things should probably be more method based, but cost/benefit analysis in my head says to leave as I have.