-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importer model fixes #15322
Importer model fixes #15322
Conversation
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
PR Summary
|
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
We had pulled the uniqueness constraint on models somewhere along the line, which made importing easier and less noisy, but also allowed duplicate names to be created via API and UI, which can cause confusion to the user. If yo have 4 "Macbook Pro 13", which is the "real" one?
This PR adds it back in, but allows for the same model name as long as the model_number is different.
This also adds a nicer message if the asset tag already exists in the spreadsheet but the update button has not been checked.
If the update button is not checked, it will quietly update with the newer values, as it's always done.