Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tecnickcom/tcpdf from version 6.7.4 to 6.7.5 to address the security vulnerability CVE-2024-22640 #14661

Merged
merged 1 commit into from
May 6, 2024

Conversation

franceslui
Copy link

No description provided.

@franceslui franceslui requested a review from snipe as a code owner April 29, 2024 23:47
Copy link

welcome bot commented Apr 29, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@probot-autolabeler probot-autolabeler bot added backend dependencies Pull requests that update a dependency file labels Apr 29, 2024
@snipe
Copy link
Owner

snipe commented Apr 30, 2024

Can you provide a little more info here? Also we should probably lock that version into composer.json

@franceslui
Copy link
Author

franceslui commented Apr 30, 2024

Thank you for your comment of asking me to provide information of my pull request.

We use Snipe-IT to manage our hardware inventory.

When we ran
ddev composer audit
we got the following error:

❯ ddev composer audit
Found 1 security vulnerability advisory affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Package           | tecnickcom/tcpdf                                                                 |
| Severity          | medium                                                                           |
| CVE               | CVE-2024-22640                                                                   |
| Title             | TCPDF vulnerable to Regular Expression Denial of Service                         |
| URL               | https://github.com/advisories/GHSA-mx3p-fhpw-x6rv                                |
| Affected versions | <=6.7.4                                                                          |
| Reported at       | 2024-04-19T18:31:11+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
Found 6 abandoned packages:
+--------------------------+----------------------------------------------------------------------------------+
| Abandoned Package        | Suggested Replacement                                                            |
+--------------------------+----------------------------------------------------------------------------------+
| doctrine/reflection      | roave/better-reflection                                                          |
| fruitcake/laravel-cors   | none                                                                             |
| laravelcollective/html   | spatie/laravel-html                                                              |
| nunomaduro/larastan      | larastan/larastan                                                                |
| phpunit/php-token-stream | none                                                                             |
| swiftmailer/swiftmailer  | symfony/mailer                                                                   |
+--------------------------+----------------------------------------------------------------------------------+
Composer [audit] failed, composer command failed: exit status 7. stderr=

To fix the error, I ran
ddev composer update tecnickcom/tcpdf

I could confirm the error was fixed by running ddev composer audit again:

❯ ddev composer audit
No security vulnerability advisories found.
Found 6 abandoned packages:
+--------------------------+----------------------------------------------------------------------------------+
| Abandoned Package        | Suggested Replacement                                                            |
+--------------------------+----------------------------------------------------------------------------------+
| doctrine/reflection      | roave/better-reflection                                                          |
| fruitcake/laravel-cors   | none                                                                             |
| laravelcollective/html   | spatie/laravel-html                                                              |
| nunomaduro/larastan      | larastan/larastan                                                                |
| phpunit/php-token-stream | none                                                                             |
| swiftmailer/swiftmailer  | symfony/mailer                                                                   |
+--------------------------+----------------------------------------------------------------------------------+

Could you accept my pull request for upgrading tecnickcom/tcpdf from 6.7.4 to 6.7.5? Thank you.

@franceslui franceslui changed the title Fixes CVE-2024-32489 Upgrade tecnickcom/tcpdf from version 6.7.4 to 6.7.5 to address the security vulnerability CVE-2024-22640 May 1, 2024
@joelpittet
Copy link
Contributor

joelpittet commented May 1, 2024

@snipe RE "Also we should probably lock that version into composer.json" are planning to lock all your dependencies?

Over in Drupal land we have a locked version of the core dependencies in a separate project https://github.com/drupal/core-recommended/ Is that what kinda what you're going for (not the separate project but the dependency lock down)?

GitHub
Metapackage that builds specific versions of drupal core based off of a lockfile. - drupal/core-recommended

@snipe snipe merged commit 19fb79f into snipe:develop May 6, 2024
2 checks passed
Copy link

welcome bot commented May 6, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants